cmake: require YMM asm for inline AVX probe#2385
Open
cary-ilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
cmake: require YMM asm for inline AVX probe#2385cary-ilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
cary-ilm wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
The existing `OPENEXR_IMF_HAVE_GCC_INLINE_ASM_AVX` `try-compile` could succeed on legacy toolchains that assemble `xgetbv/vzeroupper` but reject YMM/VEX instructions, leading to later build failures. This adds `vmovaps %%ymm0` to the `__asm__` call in `check_cxx_source_compiles` call because it's needed by the DWA encoder/decoder. That way, if the probe fails, the DWA code path doesn't attempt to use the missing instructions. Should resolve AcademySoftwareFoundation#1415 Made-with: Cursor Signed-off-by: Cary Phillips <cary@ilm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
OPENEXR_IMF_HAVE_GCC_INLINE_ASM_AVXtry-compilecould succeed on legacy toolchains that assemblexgetbv/vzeroupperbut reject YMM/VEX instructions, leading to later build failures.This adds
vmovaps %%ymm0to the__asm__call incheck_cxx_source_compilescall because it's needed by the DWA encoder/decoder. That way, if the probe fails, the DWA code path doesn't attempt to use the missing instructions.Should resolve #1415
Made-with: Cursor