Environment
Operating System: any
Version / Commit SHA: master
CMake Version: any
Compiler: irrelevant
Describe the problem
OpenVDB provides its own FindOpenVDB file. Instead, it should provide an openvdb-config.cmake (or OpenVDBConfig.cmake) file which just provides the information directly. OpenVDB's install tree already knows where everything is and having to re-find it is unnecessary work.
Please just export the targets and include them from the config file (which can do the necessary component work to only include the targets that are requested).
Additionally, there are issues related to policy scope. Performing cmake_minimum_required in an included file leaks the policy settings from it to the caller. Such calls should instead be:
cmake_policy(PUSH)
cmake_policy(VERSION 3.12)
# Rest of the script.
cmake_policy(POP)
so that the settings don't "leak" out.
Environment
Operating System: any
Version / Commit SHA: master
CMake Version: any
Compiler: irrelevant
Describe the problem
OpenVDB provides its own
FindOpenVDBfile. Instead, it should provide anopenvdb-config.cmake(orOpenVDBConfig.cmake) file which just provides the information directly. OpenVDB's install tree already knows where everything is and having to re-find it is unnecessary work.Please just export the targets and include them from the config file (which can do the necessary component work to only include the targets that are requested).
Additionally, there are issues related to policy scope. Performing
cmake_minimum_requiredin an included file leaks the policy settings from it to the caller. Such calls should instead be:so that the settings don't "leak" out.