Skip to content

Improved coverage #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 4, 2019
Merged

Improved coverage #62

merged 10 commits into from
Mar 4, 2019

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Jun 15, 2018

Merge after #57

@ghost ghost assigned ErikBjare Jun 15, 2018
@ghost ghost added the review label Jun 15, 2018
@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

Merging #62 into master will increase coverage by 1.14%.
The diff coverage is 96.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   93.97%   95.11%   +1.14%     
==========================================
  Files          33       33              
  Lines        1527     1536       +9     
  Branches      230      233       +3     
==========================================
+ Hits         1435     1461      +26     
+ Misses         47       44       -3     
+ Partials       45       31      -14
Impacted Files Coverage Δ
aw_datastore/storages/abstract.py 96.87% <ø> (ø) ⬆️
aw_datastore/storages/sqlite.py 98.6% <100%> (+0.02%) ⬆️
aw_datastore/storages/mongodb.py 97.84% <100%> (+4.44%) ⬆️
aw_transform/merge_events_by_keys.py 100% <100%> (+17.39%) ⬆️
aw_datastore/datastore.py 100% <100%> (+4.16%) ⬆️
aw_datastore/storages/peewee.py 99.21% <100%> (+0.01%) ⬆️
aw_datastore/storages/memory.py 94.2% <80%> (+3.29%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea3669...ea6e16c. Read the comment docs.

@johan-bjareholt
Copy link
Member

For a peewee->sqlite database migration to start these are the criterias:

  • Start a Datastore object with sqlite backend
  • There does not exist a previous sqlite database
  • There does exist a previous peewee.v2.db database

So the solution to avoid a migration during testing would be to run the datastore tests with sqlite before running them with peewee.

@ErikBjare ErikBjare merged commit 9e21037 into master Mar 4, 2019
@ghost ghost removed the review label Mar 4, 2019
@ErikBjare ErikBjare deleted the dev/coverage branch March 4, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants