function best practices #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
standardizing functions used through the connector to meet best practice as defined by PSScriptAnalyzer
|
PSScriptAnalyzer results: 🛑 [0] Errors, |
PSScriptAnalyzer currently has an issue when using parameters inside of [scriptblock] which is the basis for Test-EmailPattern and Get-TierMembership to perform their initial filtering.
|
PSScriptAnalyzer results: 🛑 [0] Errors, |
AdhocAdam
added a commit
that referenced
this pull request
Mar 11, 2023
* function best practices (#431) * function best practices standardizing functions used through the connector to meet best practice as defined by PSScriptAnalyzer * PSScriptAnalyzer, warning suppression PSScriptAnalyzer currently has an issue when using parameters inside of [scriptblock] which is the basis for Test-EmailPattern and Get-TierMembership to perform their initial filtering. * ensure single work item returned (#432) proposed fix to ensure the most recently modified work item with an attachment that matches the conversation id is used * Exchange documentation (#436) providing notes on what the section of Exchange code does * Additional logging (#437) * take keyword logging in the event a take action fails, log an event * logging level logic adding logic to ensure event only logs when the logging level is at least 2 * incorrect logging level instead of 2 for warning, it should be 3 for error * logging, AD Group Voting Adding log events for ELSE conditions when Voting on behalf of AD Groups * indent code block (#438) Indent IF statement in the Review Activity section of Update-WorkItem * code formatting remove trailing whitespace * Else, Custom Rules (#439) In the event Custom Rules are not enabled and a message exists in the inbox that is NOT an email, meeting, or digitally signed/encrypted email. Log an event that explains why this event occurred and how to prevent it in the future. * reviewing dev (#440) * updating log message Upon review, the only reason this section of could would be triggered is for the single condition of "Custom Rules are not enabled" instead of "Custom Rules not enabled + Unknown Message Class" * function formatting/syntax updating remaining functions to follow the consistency of the others featured throughout the connector with a param block, and notes detailing the purpose of each parameter * Valid Reviewer logging (#441) Introducing logging on Review Activities to capture if the sender of the email is in fact a valid Reviewer on the Review Activity * release notes (#442) * release notes updating inline release notes for next version * typo found a typo when reviewing release notes
AdhocAdam
added a commit
that referenced
this pull request
Mar 14, 2023
In #431 the $alias parameter was removed. This parameter is required to use Templates that have 1 or more Activities on them.
AdhocAdam
added a commit
that referenced
this pull request
Mar 14, 2023
In #431 the $alias parameter was removed. This parameter is required to use Templates that have 1 or more Activities on them.
Merged
AdhocAdam
added a commit
that referenced
this pull request
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizing functions used through the connector for consistency and to follow best practice as defined by PSScriptAnalzyer.