Skip to content

v6 - Apply styling to components #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

v6 - Apply styling to components #2231

merged 3 commits into from
Jul 21, 2025

Conversation

OscarSpruit
Copy link
Contributor

Description

  • Add AdyenCheckoutTheme as a parameter in AdyenPaymentFlow
  • Apply AdyenCheckoutTheme to composables
  • Pass dark/light colors in example implementation

@OscarSpruit OscarSpruit requested a review from a team as a code owner July 18, 2025 12:31
@OscarSpruit OscarSpruit added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Jul 18, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @OscarSpruit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive theming mechanism for Adyen checkout components. By adding an AdyenCheckoutTheme parameter to the AdyenPaymentFlow composable, it enables developers to easily customize the look and feel of the checkout UI, supporting different color schemes like dark and light mode. This significantly improves the flexibility and brand consistency for applications integrating Adyen's payment flow.

Highlights

  • Theming Integration: The AdyenPaymentFlow composable now accepts an AdyenCheckoutTheme parameter, allowing for custom styling of the checkout components.
  • Theme Application: The AdyenPaymentFlow internally applies the provided AdyenCheckoutTheme to its child composables, ensuring that the UI elements respect the defined theme.
  • Example Implementation: The example application demonstrates how to create and pass AdyenCheckoutTheme instances, dynamically switching between dark and light color schemes based on the system theme.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces theming capabilities to the Adyen payment flow composable by adding an AdyenCheckoutTheme parameter. The changes correctly apply this theme within the AdyenPaymentFlow and demonstrate its usage in the example application.

My review includes a high-severity issue in the example app where the theme is not reactive to system dark/light mode changes, and a medium-severity maintainability suggestion regarding a naming collision between a data class and a composable function.

@OscarSpruit OscarSpruit force-pushed the chore/apply-styling branch from c1386bc to 8350e50 Compare July 18, 2025 13:04
Copy link
Contributor

✅ No public API changes

Copy link

@OscarSpruit OscarSpruit merged commit 072e39e into main Jul 21, 2025
15 checks passed
@OscarSpruit OscarSpruit deleted the chore/apply-styling branch July 21, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants