Skip to content

chore: Sync Endo 2025-07-11#11594

Merged
mergify[bot] merged 16 commits intomasterfrom
kris-sync-endo-2025-07-12-05-43-43
Jul 18, 2025
Merged

chore: Sync Endo 2025-07-11#11594
mergify[bot] merged 16 commits intomasterfrom
kris-sync-endo-2025-07-12-05-43-43

Conversation

@kriskowal
Copy link
Copy Markdown
Member

@endo/immutable-arraybuffer 1.1.2

  • Removes @endo/immutable-arraybufer/shim-hermes.js and absorbs the necessary features into @endo/immutable-arraybuffer/shim.js. We are not qualifying this as a breaking change since the feature did not exist long enough to become relied upon.

@endo/marshal 1.8.0

  • Introduces an environment variable config option ENDO_RANK_STRINGS to change the rank ordering of strings from the current (incorrect) ordering by UTF-16 code unit used by JavaScript's < and .sort() operations to (correct and OCapN-conformant) ordering by Unicode code point. It currently defaults to "utf16-code-unit-order", matching the previously-unconditional behavior.

@endo/pass-style 1.6.3

  • The exported function name isObject is ambiguous. It is unclear whether it includes functions or not. (It does.) To avoid this confusion, we're deprecating isObject and suggesting to use the new export isPrimitive instead, that has the opposite answer. IOW, for all x, isObject(x) === !isPrimitive(x)

@endo/patterns 1.7.0

  • @endo/marshal introduces an environment variable config option ENDO_RANK_STRINGS to change the rank ordering of strings from the current (incorrect) ordering by UTF-16 code unit used by JavaScript's < and .sort() operations to (correct and OCapN-conformant) ordering by Unicode code point. It currently defaults to "utf16-code-unit-order", matching the previously-unconditional behavior.
    • @endo/patterns provides a compareKeys partial order that delegates some ordering, including strings, to the rank ordering provided by @endo/marshal. So when the ENDO_RANK_STRINGS default is not overridden, then compareKeys also follows the (incorrect) UTF-16 code unit order. But when it is overridden, then compareKeys also follows the (correct) Unicode code-point order.
  • In errors explaining why a specimen does not match a pattern, sometimes the error message contains a quoted form of a nested pattern. This quoting was done with q, producing an uninformative rendering of these nested patterns. Now this quoting is done with qp, which renders these nested patterns into readable Justin source code.

@endo/pass-style 1.6.2

  • Fixes so that the package initializes on platforms that lack ArrayBuffer.prototype.transferToImmutable.

@endo/compartment-mapper 1.6.2

  • Produces a stub for require.extensions in CommonJS modules to increase ecosystem compatibility.

@endo/immutable-arraybuffer 1.1.1

  • Captures structuredClone early so that scuttling all properties of globalThis after initializing @endo/immutable-arraybuffer or @endo/immutable-arraybuffer/shim.js does not interfere with this module's designed behavior.

@endo/pass-style v1.6.1

BROKEN BUT PATCHED in 1.6.2, contains a fix but published with broken dependency versions. Inadvertently published without amending workspace protocol dependencies.

  • Fixes so that the package initializes on platforms that lack ArrayBuffer.prototype.transferToImmutable and recognizes immutable ArrayBuffers as having a pass-style of byteArray on platforms have a sliceToImmutable, even if that is emulated with a shim using slice, even if they lack transferToImmutable.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jul 12, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: b1a59fe
Status: ✅  Deploy successful!
Preview URL: https://e3236950.agoric-sdk.pages.dev
Branch Preview URL: https://kris-sync-endo-2025-07-12-05.agoric-sdk.pages.dev

View logs

@kriskowal kriskowal force-pushed the kris-sync-endo-2025-07-12-05-43-43 branch 3 times, most recently from fc09c20 to 7cc43e4 Compare July 16, 2025 00:53
@kriskowal kriskowal force-pushed the kris-sync-endo-2025-07-12-05-43-43 branch 2 times, most recently from a59c694 to 1f66a39 Compare July 17, 2025 22:31
@kriskowal kriskowal added the force:integration Force integration tests to run on PR label Jul 17, 2025
@kriskowal kriskowal marked this pull request as ready for review July 17, 2025 22:59
@kriskowal kriskowal requested a review from a team as a code owner July 17, 2025 22:59
@kriskowal kriskowal requested a review from AgoricTriage July 17, 2025 22:59
// This test runs at the cusp of meter failure and is sensitive to changes to
// the underlying platform.
t.log(
'adjust the remaining computrons figure if this test fails due to platform changes and run a benchmark to check the wallclock impact',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! From this message, how would someone find out how to "run a benchmark to check the wallclock impact"?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to have to ask in chat for now. The lore for this is too fresh to commit to ink. When we do, we’ll want to record it in MAINTAINERS.md with all else of the kind.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Copy Markdown
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erights
Copy link
Copy Markdown
Member

erights commented Jul 17, 2025

endojs/endo#1538 stopped exporting trivialComparator. But compareKeys.js was already not importing it by then. What old version of endo is this failed integration test checking? What's the scenario where we care if an old @endo/patterns links with a new @endo/marshal?

@kriskowal kriskowal added the automerge:rebase Automatically rebase updates, then merge label Jul 18, 2025
@kriskowal kriskowal force-pushed the kris-sync-endo-2025-07-12-05-43-43 branch from b426b32 to b1a59fe Compare July 18, 2025 23:17
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 18, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #11594 has been manually updated.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@kriskowal
Copy link
Copy Markdown
Member Author

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 18, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify Bot merged commit 6e8ce0f into master Jul 18, 2025
90 of 91 checks passed
@mergify mergify Bot deleted the kris-sync-endo-2025-07-12-05-43-43 branch July 18, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants