TypeScript 5.1

package.json

@@ -14,8 +14,8 @@
     "@jessie.js/eslint-plugin": "^0.4.0",
     "@types/express": "^4.17.17",
     "@types/node": "^16.13.0",
-    "@typescript-eslint/eslint-plugin": "^5.59.11",
-    "@typescript-eslint/parser": "^5.59.11",
+    "@typescript-eslint/eslint-plugin": "^5.61.0",
+    "@typescript-eslint/parser": "^5.61.0",
     "ava": "^5.3.0",
     "c8": "^7.13.0",
     "conventional-changelog-conventionalcommits": "^4.6.0",
@@ -30,7 +30,7 @@
     "lerna": "^3.22.1",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.8.3",
-    "typescript": "~4.7.4"
+    "typescript": "~5.1.6"
   },
   "engines": {
     "node": "^16.13 || ^18.12"

packages/agoric-cli/src/commands/auction.js

@@ -7,7 +7,11 @@ import { outputActionAndHint } from '../lib/wallet.js';
 const { Fail } = assert;
 
 /** @typedef {import('@agoric/governance/src/contractGovernance/typedParamManager.js').ParamTypesMap} ParamTypesMap */
-/** @template M @typedef {import('@agoric/governance/src/contractGovernance/typedParamManager.js').ParamTypesMapFromRecord<M>} ParamTypesMapFromRecord */
+
+/**
+ * @template {ParamStateRecord} M
+ * @typedef {import('@agoric/governance/src/contractGovernance/typedParamManager.js').ParamTypesMapFromRecord<M>} ParamTypesMapFromRecord
+ */
 
 /**
  * @template {ParamTypesMap} M

packages/eslint-config/package.json

@@ -27,8 +27,8 @@
   "peerDependencies": {
     "@endo/eslint-plugin": "^0.4.4",
     "@jessie.js/eslint-plugin": "^0.4.0",
-    "@typescript-eslint/eslint-plugin": "^5.59.11",
-    "@typescript-eslint/parser": "^5.59.11",
+    "@typescript-eslint/eslint-plugin": "^5.61.0",
+    "@typescript-eslint/parser": "^5.61.0",
     "eslint": "^8.36.0",
     "eslint-config-airbnb-base": "^15.0.0",
     "eslint-plugin-github": "^4.8.0",

packages/governance/src/contractHelper.js

@@ -32,7 +32,7 @@ const publicMixinAPI = harden({
 
 /**
  * @param {ZCF<GovernanceTerms<{}> & {}>} zcf
- * @param {import('./contractGovernance/typedParamManager').TypedParamManager<unknown>} paramManager
+ * @param {import('./contractGovernance/typedParamManager').TypedParamManager<any>} paramManager
  */
 export const validateElectorate = (zcf, paramManager) => {
   const { governedParams } = zcf.getTerms();
@@ -53,7 +53,7 @@ harden(validateElectorate);
 /**
  * Utility function for `makeParamGovernance`.
  *
- * @template T
+ * @template {import('./contractGovernance/typedParamManager.js').ParamTypesMap} T
  * @param {ZCF<GovernanceTerms<{}> & {}>} zcf
  * @param {import('./contractGovernance/typedParamManager').TypedParamManager<T>} paramManager
  */

packages/inter-protocol/scripts/init-core.js

@@ -47,15 +47,15 @@ const installKeyGroups = {
 };
 
 /**
+ * @template I
+ * @template R
  * @param {object} opts
  * @param {(i: I) => R} opts.publishRef
  * @param {(m: string, b: string, opts?: any) => I} opts.install
  * @param {<T>(f: T) => T} [opts.wrapInstall]
  *
  * @param {object} [options]
  * @param {{ committeeName?: string, committeeSize?: number}} [options.econCommitteeOptions]
- * @template I
- * @template R
  */
 export const committeeProposalBuilder = async (
   { publishRef, install: install0, wrapInstall },
@@ -83,13 +83,13 @@ export const committeeProposalBuilder = async (
 };
 
 /**
+ * @template I
+ * @template R
+ *
  * @param {object} opts
  * @param {(i: I) => R} opts.publishRef
  * @param {(m: string, b: string, opts?: any) => I} opts.install
  * @param {<T>(f: T) => T} [opts.wrapInstall]
- *
- * @template I
- * @template R
  */
 export const mainProposalBuilder = async ({
   publishRef,

packages/inter-protocol/src/proposals/startEconCommittee.js

@@ -22,7 +22,7 @@ const sanitizePathSegment = name => {
 
 /**
  * @param {import('./econ-behaviors').EconomyBootstrapPowers} powers
- * @param {object} [config]
+ * @param {object} config
  * @param {object} [config.options]
  * @param {EconCommitteeOptions} [config.options.econCommitteeOptions]
  */

packages/inter-protocol/src/proposals/startPSM.js

@@ -300,7 +300,7 @@ harden(startPSM);
  * TODO: address redundancy with publishInterchainAssetFromBank
  *
  * @param {EconomyBootstrapPowers & WellKnownSpaces & ChainStorageVatParams} powers
- * @param {{options?: { anchorOptions?: AnchorOptions } }} [config]
+ * @param {{options: { anchorOptions?: AnchorOptions } }} config
  */
 export const makeAnchorAsset = async (
   {

packages/inter-protocol/test/swingsetTests/fluxAggregator/bootstrap-fluxAggregator-service-upgrade.js

@@ -46,6 +46,7 @@ export const buildRootObject = async () => {
    */
   const installations = {};
 
+  // @ts-expect-error TODO make fluxAggregator publicFacet support all governance methods (or pare down governance API)
   /** @type {import('@agoric/governance/tools/puppetContractGovernor').PuppetContractGovernorKit<import('../../../src/price/fluxAggregatorContract.js').prepare>} */
   let governorFacets;
   /** @type {ReturnType<Awaited<ReturnType<import('../../../src/price/fluxAggregatorContract.js').prepare>>['creatorFacet']['getLimitedCreatorFacet']>} */

packages/inter-protocol/test/vaultFactory/vaultFactoryUtils.js

@@ -59,7 +59,7 @@ export const defaultParamValues = debtBrand =>
  * @param {Array<NatValue> | Ratio} priceOrList
  * @param {RelativeTime} quoteInterval
  * @param {Amount | undefined} unitAmountIn
- * @param {Partial<import('../../src/auction/params.js').AuctionParams>} [actionParamArgs]
+ * @param {Partial<import('../../src/auction/params.js').AuctionParams>} actionParamArgs
  */
 export const setupElectorateReserveAndAuction = async (
   t,

packages/vats/src/core/lib-boot.js

@@ -12,7 +12,7 @@ import { makePromiseSpace } from './promise-space.js';
 const { Fail, quote: q } = assert;
 
 /**
- * @typedef {true | string | { [key: string]: BootstrapManifestPermit }} BootstrapManifestPermit
+ * @typedef {true | string | { [key: string]: BootstrapManifestPermit | undefined }} BootstrapManifestPermit
  */
 
 /**

packages/vats/src/core/types.js

@@ -76,18 +76,18 @@
  */
 
 /**
+ * @template T
  * @typedef {object} Producer<T>
  * @property {(v: ERef<T>) => void} resolve
  * @property {(r: unknown) => void} reject
  * @property {(reason?: unknown) => void} reset
- * @template T
  */
 /**
  * @typedef {{ bundleName?: string, bundleID?: string }} VatSourceRef
  */
 /**
- * @typedef {(name: string, sourceRef?: VatSourceRef) => T} VatLoader<T>
  * @template T
+ * @typedef {(name: string, sourceRef?: VatSourceRef) => T} VatLoader<T>
  */
 
 /**

packages/vats/src/proposals/restart-vats-proposal.js

@@ -61,7 +61,6 @@ export const restartVats = async ({ consume }, { options }) => {
     // TODO document that privateArgs cannot contain promises
     // TODO try making all the contract starts take resolved values
     const privateArgs = await deeplyFulfilledObject(
-      // @ts-expect-error cast
       harden(instancePrivateArgs.get(instance) || {}),
     );
 

packages/xsnap-lockdown/test/test-inspect.js

@@ -90,6 +90,7 @@ test('unconfined inspect', async t => {
     const [toEval, toRender] = Array.isArray(testCase)
       ? testCase
       : [testCase, testCase];
+    // @ts-expect-error Left side of comma operator is unused and has no side effects.
     // eslint-disable-next-line no-eval
     const evaled = (1, eval)(`(${toEval})`);
     // t.log(evaled);

packages/xsnap/test/test-xs-js.js

@@ -167,6 +167,7 @@ test('round-trip byte sequences via JSON including string literals', async t =>
       .fill(0)
       .map((_, i) => `\\x${i.toString(16).padStart(2, '0')}`)
       .join('');
+    // @ts-expect-error Left side of comma operator is unused and has no side effects.
     // eslint-disable-next-line no-eval
     const bstring2 = (1, eval)(`"${joctets}"`);
     send(bstring1 === bstring2);

packages/zoe/src/contractFacet/internal-types.js

@@ -1,7 +1,7 @@
 // @jessie-check
 
 /**
- * @typedef {( {zcf: ZCF} ) => void} TestJigSetter
+ * @typedef {( {zcf}: {zcf: ZCF} ) => void} TestJigSetter
  */
 
 /**

packages/zoe/src/contracts/autoswap.js

@@ -167,6 +167,7 @@ const start = async zcf => {
     } = swapSeat.getProposal();
 
     assert(isNatValue(wantedAmountOut.value));
+    assert.typeof(amountIn.value, 'bigint');
 
     const tradePrice = getOutputPrice(
       wantedAmountOut.value,