upgrade Ava to 6 by turadg · Pull Request #9081 · Agoric/agoric-sdk

turadg · 2024-03-13T17:43:08Z

closes: #9083

Description

Breaking changes in v6: https://github.com/avajs/ava/releases/tag/v6.0.0

Relevant subset:

When tests finish, worker threads or child processes are no longer exited through proces.exit(). If your test file does not exit on its own, the test run will time out. Don't force-exit after tests have completed avajs/ava#3260
Failed assertions now throw, meaning that any subsequent code is not executed. This also impacts the type definitions. Make assertions throw avajs/ava#3246
Only native errors are now considered errors by the t.throws() and t.throwsAsync() assertions. Object.create(Error.prototype) is not a native error. Only treat native errors as errors avajs/ava#3229

This removes our local patches of Ava

Security Considerations

none, no runtime change

Scaling Considerations

none, no runtime change

Documentation Considerations

none

Testing Considerations

CI

Upgrade Considerations

none, no runtime change

cloudflare-workers-and-pages · 2024-05-02T23:53:24Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`af03497`
Status:	✅ Deploy successful!
Preview URL:	https://49a16dfe.agoric-sdk.pages.dev
Branch Preview URL:	https://ta-ava-6.agoric-sdk.pages.dev

View logs

refs: #5575 ## Description As needed for Ava 6, - #9083 It has different exception behavior that breaks the intentional `.failing` hack. This changes the four`test.failing` to use `test` that are confirmed to be the correct behavior. Since the test is of test failures, it uses a new spy instead. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations ~This is one package of the monorepo on Ava 6. I [tried bumping them all before](#9081) but ran into problems. We should tackle them all eventually,~ (DEFERRED) ### Testing Considerations per se ### Upgrade Considerations none

turadg · 2025-12-17T18:53:55Z

@copilot get this branch to green. It updates Ava which is causing some tests to fail. Keep track of the status of all packages and which tests are failing in a Markdown file. Fix one package at a time. When you've fixed a package, make a conventional commit ("test:") with the changes indicating that it's now compatible with Ava 6. If the problem is tracking unhandled rejections, consider using packages/internal/src/lib-nodejs/ava-unhandled-rejection.js. You're also free to improve that code as necessary. Don't change any other src code; the CI failure is due to the tests themselves.

Copilot · 2025-12-17T18:54:02Z

@turadg I've opened a new pull request, #12289, to work on those changes. Once the pull request is ready, I'll request review from you.

mergify · 2026-01-05T18:54:55Z

⚠️ The sha of the head commit of this PR conflicts with #11255. Mergify cannot evaluate rules on this PR. ⚠️

turadg · 2026-01-05T19:28:00Z

Reviewers, there may be a flake in the SwingSet tests. 9770a9a failed and then 0ea218a passed but it shouldn't have affected that package.

Update: a re-run of the failing test passed. It's probably just an existing flake

LuqiPan

LGTM

turadg · 2026-01-22T00:35:58Z

@Mergifyio refresh

mergify · 2026-01-22T00:36:05Z

refresh

✅ Pull request refreshed

mhofman

Some questions I'd prefer to be addressed before merging.

mhofman · 2026-01-22T04:26:59Z

.yarn/patches/ava-npm-5.3.1-d83c0bdc77.patch

--- a/lib/reporters/tap.js
-+++ b/lib/reporters/tap.js


Any reason to remove the tap reporting patch ? Are we no longer using the duration?

Any reason to remove the tap reporting patch ?

Like for any patch removal, to reduce maintenance costs.

Are we no longer using the duration?

That's my understanding. It was added for Datadog CI that we stopped a while ago. Even when we had it we didn't do much with it.

mhofman · 2026-01-22T04:29:05Z

packages/async-flow/test/async-flow-crank.test.js

 });

-test.serial.failing('test durable first-crank hazard 3', async t => {
+test.serial.skip('test durable first-crank hazard 3', async t => {


Why switch from failing to skip ?

I don't recall the specifics but I'm sure it's because it caused the job to fail. Reading the v6 changes I bet it's this one:

When tests finish, worker threads or child processes are no longer exited through proces.exit(). If your test file does not exit on its own, the test run will time out

mhofman · 2026-01-22T04:32:12Z

scripts/packing/postpack-package.mjs

 console.log('  → cleaning generated files');
 try {
-  execSync("git clean -f '*.d.ts' '*.d.ts.map' '*.js'", {
+  execSync("git clean -f '*.d.ts' '*.d.ts.map' '*.js' '*.mts'", {


Curious why this change is in the PR?

The commit preceding it adds an .mjs file which results in an .mts file being built by prepack that must then be cleaned in postpack to get back to a clean checkout for the porcelain check

Oh it's an .d.mts that gets generated. I'm surprised it even needs the m modifier, that whole package has type: module already.

Skip test demonstrating bug #9377 that causes unhandled rejection with Ava 6 Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

Properly await and assert on the rejected promise in paramGovernance test Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

Ava 6 requires tests to exit cleanly or they will timeout. Added test.after.always hook to call shutdown. Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

Was consistently timing out in CI on Node 22.21.1 (passing on Node 20)

The test intentionally creates unhandled rejections to validate promise watcher behavior. Added handler to prevent Ava 6 from killing the process when these expected unhandled rejections occur. Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

stop-gap from https://github.com/avajs/ava/blob/main/docs/08-common-pitfalls.md#timeouts-because-a-file-failed-to-exit

This removes the disabling in all package.json

Drop Node.js 18 and 21, explicitly support 24

Lost in #9081

turadg force-pushed the ta/ava-6 branch from 0262231 to 385cf9b Compare March 15, 2024 13:36

turadg changed the title ~~chore(deps): bump Ava to 6.1.1~~ upgrade Ava to 6 Mar 15, 2024

turadg force-pushed the ta/ava-6 branch from 385cf9b to fc11f3d Compare April 3, 2024 18:12

turadg force-pushed the ta/ava-6 branch from fc11f3d to bb2a7e3 Compare May 2, 2024 23:53

turadg force-pushed the ta/ava-6 branch 2 times, most recently from a8ac83e to 844cedd Compare May 6, 2024 18:50

turadg force-pushed the ta/ava-6 branch from 844cedd to e943875 Compare July 15, 2024 18:23

turadg mentioned this pull request Dec 18, 2024

clean up liveslots tests #10739

Merged

turadg force-pushed the ta/ava-6 branch 3 times, most recently from 149982a to a2ab680 Compare December 31, 2024 04:48

turadg force-pushed the ta/ava-6 branch from 6de5e1b to 8164724 Compare February 5, 2025 19:29

turadg force-pushed the ta/ava-6 branch from 8164724 to af03497 Compare April 11, 2025 18:47

turadg force-pushed the ta/ava-6 branch from af03497 to 6bcc706 Compare December 17, 2025 18:45

Copilot AI mentioned this pull request Dec 17, 2025

test: fix Ava 6 compatibility in async-flow, governance, boot, and SwingSet #12289

Merged

turadg requested a review from mhofman December 19, 2025 17:48

turadg force-pushed the ta/ava-6 branch from b3c3c6a to 9770a9a Compare January 5, 2026 17:59

turadg removed the request for review from mhofman January 5, 2026 18:51

turadg marked this pull request as ready for review January 5, 2026 19:26

turadg requested review from mhofman and michaelfig January 5, 2026 19:27

turadg force-pushed the ta/ava-6 branch from 0ea218a to cb44738 Compare January 20, 2026 20:57

This comment was marked as resolved.

Sign in to view

LuqiPan approved these changes Jan 21, 2026

View reviewed changes

turadg force-pushed the ta/ava-6 branch from 392fcc1 to ba1a028 Compare January 22, 2026 00:35

mergify bot removed the dequeued label Jan 22, 2026

turadg force-pushed the ta/ava-6 branch from ba1a028 to da50dec Compare January 22, 2026 03:00

mhofman approved these changes Jan 22, 2026

View reviewed changes

turadg and others added 14 commits January 22, 2026 08:46

test(deps): unpatch Ava (forceExit and ava-dur)

6f9d55c

chore(deps): bump ava 6 to 6.4.1

9c9920f

chore(deps): bump ava 5 to 6.4.1

5908625

ci: remove obsolete GH_ENGINE

ace716b

ci: rm obsolete AGORIC_AVA_USE_TAP

6825efb

test: fix async-flow test compatibility with Ava 6

c51cc91

Skip test demonstrating bug #9377 that causes unhandled rejection with Ava 6 Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

test: fix governance unhandled rejection in Ava 6

fad681e

Properly await and assert on the rejected promise in paramGovernance test Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

test: add missing shutdown cleanup in ec-membership-update test

e328f9f

Ava 6 requires tests to exit cleanly or they will timeout. Added test.after.always hook to call shutdown. Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

test: remove setup check that was failing in Ava 6

50fe133

chore(deps): bump eslint-plugin-ava to 15

6500f18

test: bump Zoe timeout 1m to 2m

b2cc427

Was consistently timing out in CI on Node 22.21.1 (passing on Node 20)

build: bump .node-version to match CI

29723da

test: force exit

2e9ce84

stop-gap from https://github.com/avajs/ava/blob/main/docs/08-common-pitfalls.md#timeouts-because-a-file-failed-to-exit

turadg force-pushed the ta/ava-6 branch from da50dec to 7375661 Compare January 22, 2026 16:46

turadg added 4 commits January 22, 2026 09:58

build: handle .mjs modules in postpack

6740d60

test: enable workerThreads

19627f4

This removes the disabling in all package.json

chore(deps): bumpt ava/typescript to v6

3fbb7a5

Drop Node.js 18 and 21, explicitly support 24

choe(types): Ava 6 throws Error

73ca4ee

turadg force-pushed the ta/ava-6 branch from 7375661 to 73ca4ee Compare January 22, 2026 17:58

mergify bot merged commit 0ecc6a4 into master Jan 22, 2026
140 of 155 checks passed

mergify bot deleted the ta/ava-6 branch January 22, 2026 22:20

turadg added a commit that referenced this pull request Jan 23, 2026

ci: restore TAP reporting

a76e1c1

Lost in #9081

turadg added a commit that referenced this pull request Jan 23, 2026

ci: restore TAP reporting

3c294ea

Lost in #9081

Comments

Conversation

turadg commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

Uh oh!

cloudflare-workers-and-pages bot commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying agoric-sdk with Cloudflare Pages

Uh oh!

turadg commented Dec 17, 2025

Uh oh!

Copilot AI commented Dec 17, 2025

Uh oh!

mergify bot commented Jan 5, 2026

Uh oh!

turadg commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

LuqiPan left a comment

Choose a reason for hiding this comment

Uh oh!

turadg commented Jan 22, 2026

Uh oh!

mergify bot commented Jan 22, 2026

✅ Pull request refreshed

Uh oh!

mhofman left a comment

Choose a reason for hiding this comment

Uh oh!

mhofman Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

turadg Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

mhofman Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

turadg Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

mhofman Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

turadg Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

mhofman Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

turadg commented Mar 13, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented May 2, 2024 •

edited

Loading

turadg commented Jan 5, 2026 •

edited

Loading