Skip to content

fix: fix v-close-popper to function on mousedown #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akryum merged 1 commit into from
Jan 17, 2024
Merged

fix: fix v-close-popper to function on mousedown #1014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/floating-vue/src/directives/v-close-popper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { supportsPassive } from '../util/env'

function addListeners (el) {
el.addEventListener('click', onClick)
el.addEventListener('mousedown', onMouseDown)
el.addEventListener('touchstart', onTouchStart, supportsPassive
? {
passive: true,
Expand All @@ -10,13 +10,13 @@ function addListeners (el) {
}

function removeListeners (el) {
el.removeEventListener('click', onClick)
el.removeEventListener('mousedown', onMouseDown)
el.removeEventListener('touchstart', onTouchStart)
el.removeEventListener('touchend', onTouchEnd)
el.removeEventListener('touchcancel', onTouchCancel)
}

function onClick (event) {
function onMouseDown (event) {
const el = event.currentTarget
event.closePopover = !el.$_vclosepopover_touch
event.closeAllPopover = el.$_closePopoverModifiers && !!el.$_closePopoverModifiers.all
Expand Down