Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a mechanism to save and apply file modification times for test data files in CI environments. The change enables tests to pass on CI by preserving and restoring the exact modification times of files in internal/testdata/local/, which are apparently critical for hardcache testing.
Key changes:
- Added
modtimes.goprogram to save/apply file modification times - Committed
modtimes.txtwith saved modification times for all test files - Updated CI workflow, Makefile, and documentation to apply times before tests
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/testdata/modtimes.go | Go program to save/apply file modification times |
| internal/testdata/modtimes.txt | Saved modification times for ~1500 test files |
| Makefile | Build modtimes tool and apply times during init |
| .github/workflows/go.yml | Run make init before tests in CI |
| CONTRIBUTING.md | Document need to run make init for local setup |
| internal/testdata/fill.sh | Save modification times after filling cache |
| README.md | Minor formatting improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.