Skip to content

Disable "Exclude multiplexed samples" for AnnData in DatasetAddProjectModal #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2025
Merged

Disable "Exclude multiplexed samples" for AnnData in DatasetAddProjectModal #1616

merged 3 commits into from
Nov 22, 2025

Conversation

@nozomione
Copy link
Member

@nozomione nozomione commented Nov 19, 2025 •
edited
Loading

Issue Number

Closes #1613

Purpose/Implementation Notes

I've fix the bug so that the "Exclude multiplexed samples" checkbox is automatically selected and disabled whenever AnnData (Python) is chosen as the Data Format via the "Add Project to Dataset" modal.

@dvenprasad , see the latest UI here. Thank you!

Changes include:

  • Selected and disabled the "Exclude multiplexed samples" checkbox in the DatasetProjectAdditionalOptions component based on the selected format value in the modal.
  • Set the excludeMultiplexed state value based on format change in the DatasetAddProjectModal component.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

N/A

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

@nozomione
(edit) disable the Exclude Multiplexed Samples checkbox in DatasetPro…
bdfefff 
…jectAdditionalOptions and set excludeMultiplexed based on user-selected format via modal
@nozomione nozomione self-assigned this Nov 19, 2025
@nozomione nozomione linked an issue Nov 19, 2025 that may be closed by this pull request
Disable "Exclude multiplexed samples" for AnnData in DatasetAddProjectModal #1613
Closed
@nozomione
(edit) add separate useEffect for format changes so that it won't res…
4c5394f 
…et default values for other additional options
@nozomione nozomione mentioned this pull request Nov 20, 2025
Merged
4 tasks
@davidsmejia davidsmejia merged commit 0aba7f7 into feature/dataset-integration Nov 22, 2025
5 checks passed
@davidsmejia davidsmejia deleted the nozomione/1613-disable-exclude-multiplexed-samples-checkbox branch November 22, 2025 00:21
@davidsmejia davidsmejia mentioned this pull request Nov 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidsmejia davidsmejia Awaiting requested review from davidsmejia davidsmejia is a code owner

@dvenprasad dvenprasad Awaiting requested review from dvenprasad

@avrohomgottlieb avrohomgottlieb Awaiting requested review from avrohomgottlieb

Assignees

@nozomione nozomione

Labels

client / front-end

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable "Exclude multiplexed samples" for AnnData in DatasetAddProjectModal

3 participants

@nozomione @davidsmejia