Skip to content

Add support to let Algobattle run inside a docker container #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 26, 2023

Conversation

ImogenBits
Copy link
Collaborator

This lets us run Algobattle inside a docker container. I'm honestly not super sure if we should actually support this since it creates some potential bugs and is not really how you should be using docker, but it's probably the best way to get it to work with the web framework.
Doing this PR now so that we have a working version for the web framework, but we should discuss long term plans sometime.

@Benezivas
Copy link
Collaborator

Thank you for the PR. I am not completely sure why we do need this wrapping inside of a docker container, yet.

Would it also be possible to let the webframework interact with an installation of algobattle not wrapped inside a docker container? If so, this may be the most robust, if maybe not completely ideal way to handle the interaction right now.

@ImogenBits
Copy link
Collaborator Author

Changed the way we interact with the host docker. Instead of using volumes we mount a parent folder from the host and create the io directories there. This resolves most of the issues with this approach. Having the docker daemon's socket be mounted like this still isn't the "prettiest" solution, but imo it's far worth it in order to have all of the setup reside in a single docker compose rather than having to set it up manually. This also lets people run the algobattle framework without ever installing python, which can come in handy.

@Benezivas Benezivas merged commit 84f5b6d into Algorithmic-Battle:4.0.0-rc Jul 26, 2023
@ImogenBits ImogenBits deleted the docker branch July 26, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants