-
Notifications
You must be signed in to change notification settings - Fork 3
Cross platform support #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross platform support #57
Conversation
Thank you for adressing issue #50 with this PR. I advocate for formulating the |
yeah sounds smart, implemented both changes |
addressing #50 this PR adds CI checks for windows and macOS. It also includes 2 very minor bugfixes that I noticed because of the more extensive testing.
There were two big problems when making this that will also impact future work:
ENTRYPOINT sleep 10
rather thanENTRYPOINT ["sleep", "10"]
) and alias a windows image to 'alpine'.Currently the tests running the whole script fail on macOS. From what I can tell this is not because of an actual OS issue or bug in our code but because installing scripts works differently than on linux/windows. I have no experience with that and can't find anything related to that on google so I'm just leaving it as is.