Skip to content

Config rework #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 78 commits into from
Dec 21, 2022
Merged

Config rework #71

merged 78 commits into from
Dec 21, 2022

Conversation

ImogenBits
Copy link
Collaborator

reworking the config parsing and CLI

@Benezivas
Copy link
Collaborator

Thank you for the PR. Could you please give a small overview of the conceptional changes that this PR brings?

@ImogenBits
Copy link
Collaborator Author

Since this is a pretty extensive PR I was planning to talk it through in our meeting later today instead of trying to explain it through text, I should probably have written that down :D

@Benezivas
Copy link
Collaborator

Thank you for the changes, there is a small bug that I noticed when running the script with the --display=ui option:

[...]
Algobattle version 4.0.0
Battle Type: <class 'algobattle.battle_wrappers.iterated.Iterated'>
╔═══════════════╦═══════════════╦═══════╦═══════╦═══════╦═══════╦═══════╦═══════╗
║      GEN      ║      SOL      ║     1 ║     2 ║     3 ║     4 ║     5 ║   AVG ║
╠═══════════════╬═══════════════╬═══════╬═══════╬═══════╬═══════╬═══════╬═══════╣
║ c4subgraphiso ║ c4subgraphiso ║ 50000 ║       ║       ║       ║       ║ 50000 ║
╚═══════════════╩═══════════════╩═══════╩═══════╩═══════╩═══════╩═══════╩═══════╝
[...]

The name of the used Battlewrapper is not correctly resolved.
Is it also intended that the names of the generating and solving teams are substituted by the problem name?
I would find it to be more reasonable to state the name of the problem seperately.

@ImogenBits
Copy link
Collaborator Author

fixed the battle wrapper name issue.

the table does show the names of the teams, but i set it so the default team name is the name of the folder the generator and solver is in. but you're right, that usually is the name of the problem not of the team. changed it so it's just "team 0".

@Benezivas
Copy link
Collaborator

Thank you, it now works as expected.

@Benezivas Benezivas merged commit ee8f682 into Algorithmic-Battle:4.0.0-rc Dec 21, 2022
@ImogenBits ImogenBits deleted the config branch December 24, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants