Replace logging messages with match object serialization #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much, this seems to behave like we discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves a bunch of code around to make it possible to serialize the match objects we generate, and removes the then unnecessary logging messages. This makes it so we can easily display the match in the web interface, and gives a much more detailed and programatically parseable view into what happened to users who are testing their code.
The cli interface is also changed marginally since we don't have a logging path anymore and we don't dump the resulting match object by default. Maybe we should default to doing that, but that would mean choosing some path on the user's device to write a bunch of json data into, which seems iffy. Since we now have a nicer cli output users shouldn't really need the resulting json file generally.