[QC-1292] Missing run number in logs from BookkeepingSink #2561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Barthelemy
commented
Jun 5, 2025
Barthelemy
commented
- added initialization of IL
- set the run number whenever we get one
- added initialization of IL - set the run number whenever we get one
Barthelemy
changed the title
|
wip because I don't know how to test |
justonedev1
approved these changes
Jun 13, 2025
knopers8
requested changes
Jun 16, 2025
| @@ -70,6 +77,7 @@ void BookkeepingQualitySink::send(const std::string& grpcUri, const BookkeepingQ | |||
| } | |||
| if (!runNumber.has_value()) { | |||
| runNumber = flagCollection->getRunNumber(); | |||
| QcInfoLogger::setRun(runNumber.value()); | |||
There was a problem hiding this comment.
This is quite late to set the run number. send happens only at the end of run. Would you be able to retrieve run number during start of run as a fairmq property, similarly to other Runners?
There was a problem hiding this comment.
yes, this is a fair point. I wanted to be consistent with what we pass to the BK but it makes more sense like that.
add a valid bookkeeping URL to a QC config file and add |
Barthelemy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.