Replace react-toastr with react-s-alert #1216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2017
Closed
|
Great! We recently noticed that To be honest, why does a table need notifications at all? |
Owner
Author
Actually, no need absolutely. That's really pretty bad decision about two years ago... For the notification, we need it to display some message for invalid input for cell editing or insert. But at first, I should make notification can be pluggable or use something like that. For now, it's hard to get ride of it |
This was referenced Apr 29, 2017
Owner
Author
|
Reopen on #1534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #838 issue and so cause a series of issues about dependency or no found for
@allenfang/react-toastr, Because there's no way to fix #838, only the creator ofreact-toastrcan fix it internally, so that I create@allenfang/react-toastr.Anyway,
react-toastrseems like have no any update and activity for a long time, so I decide to replacereact-toastrwith react-s-alert, it's much easy to use and customize and still have activity in these two day.I also publish a beta version,
v4.0.0-beta.1, please upgrade and test it. Any enhancement forreact-s-alertwill be enhanced in near future.Related issues:
#838
#861
#863
#898
#969
#1054
#1081
#1152
#1171
#1191
#1204
Finally, sorry that I don't face this issue actively, it's my bad and for this PR can save some people.
Let me know if you have any concern questions and feedback.
I plan to release
v4.0.0in these couple days if without any critical bugs.