docs: Add ADR for mapping and filtering in expressions#18768
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds an ADR that records choosing JMESPath (alternative A6) to enable mapping and filtering in Altinn Studio expressions, describes the problem and twelve decision drivers, documents seven alternatives with examples, evaluates pros/cons, and includes a decision matrix. ChangesMaps and Filters in Expressions ADR
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (2)
docs/adr/2026-05-11-maps-and-filters-in-expressions.md (2)
25-26: 💤 Low valueOptional: Consider adding a comma for clarity.
The phrase "that is to say not considering memory limits" could be slightly clearer with a comma after "say".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/adr/2026-05-11-maps-and-filters-in-expressions.md` around lines 25 - 26, Edit the sentence in the ADR so the parenthetical phrase reads "that is to say, not considering memory limits" — i.e., insert a comma after "say" in the phrase "that is to say not considering memory limits" (look for the line containing "**B3:** It should theoretically (that is to say not considering memory limits) support...") to improve clarity.
30-32: 💤 Low valueOptional: Consider simplifying the intensifier.
The phrase "a very good chance" could be simplified to "a strong likelihood" or similar phrasing for more direct technical writing.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/adr/2026-05-11-maps-and-filters-in-expressions.md` around lines 30 - 32, Update the wording for bullet "B7" in the ADR (the line that currently reads "This might be considered 'nice to have' since there is a very good chance we will need lambda functions at some point anyway.") to use a more direct intensifier such as "a strong likelihood" (e.g., replace "a very good chance" with "a strong likelihood" or similar concise phrasing) so the sentence reads more technically direct while preserving the original meaning.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/adr/2026-05-11-maps-and-filters-in-expressions.md`:
- Around line 25-26: Edit the sentence in the ADR so the parenthetical phrase
reads "that is to say, not considering memory limits" — i.e., insert a comma
after "say" in the phrase "that is to say not considering memory limits" (look
for the line containing "**B3:** It should theoretically (that is to say not
considering memory limits) support...") to improve clarity.
- Around line 30-32: Update the wording for bullet "B7" in the ADR (the line
that currently reads "This might be considered 'nice to have' since there is a
very good chance we will need lambda functions at some point anyway.") to use a
more direct intensifier such as "a strong likelihood" (e.g., replace "a very
good chance" with "a strong likelihood" or similar concise phrasing) so the
sentence reads more technically direct while preserving the original meaning.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0ff20107-d980-4d00-9716-0e2abe0eddbc
📒 Files selected for processing (1)
docs/adr/2026-05-11-maps-and-filters-in-expressions.md
Description
This pull request adds an ADR (Architecture Decision Record) that summarises our discussion on mapping and filtering in expressions.
Verification
Summary by CodeRabbit
Release Notes