refactor: move ConditionalWrapper to app#18838
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughConditionalWrapper is exported from the ChangesConditionalWrapper library centralisation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
walldenfilippa
left a comment
There was a problem hiding this comment.
Ser bra ut! 🥳 Hadde et mindre spørsmål i en av filene.
There was a problem hiding this comment.
Lurte litt på hvorfor disse ble lagt til her? Om dem heller skal være i en annen PR?
src/app-components/TimePicker/TimeSegment/TimeSegment.tsx
src/features/instantiate/containers/UnknownError.module.css
src/features/instantiate/containers/UnknownErrorDetails.module.css
src/features/instantiate/containers/UnknownErrorDetails.tsx
src/layout/SigningDocumentList/api.test.ts
There was a problem hiding this comment.
Vi oppdaterer den for hver PR hvor vi flytter en komponent slik at vi får opp en advarsel i legacy repoet om man gjør endringer der det er gjort noe i minorepo, vi følger de here:
Instructions
- The task is to migrate @../../../src/App/frontend/src/app-components/$ARGUMENTS[0] to @../../../libs/form-component/src/app-components
- Ask the user any clarifying questions you have
- checkout a new branch called refactor/move-$ARGUMENTS[0]-to-app
- Make a plan to move
- Move the component
- Fix any imports using the component
- Remove forwardRef if in use in the component
- Add unit tests for the component if they don't exist
- Add a suitable storybook story for the component
- Go to @../../../src/App/frontend and run
npx tsx scripts/compare-frontend-repos.ts update - Output a PR description based on this format ../../../.github/pull_request_template.md. Keep it short and simple, keep the checkboxes, tick the relevant boxes
…onalWrapper-to-app
…onalWrapper-to-app
…onalWrapper-to-app
Related issue : #18809
Description
ConditionalWrapperto@app/form-component@app/form-componentVerification
Summary by CodeRabbit
New Features
Documentation
Tests
Chores