Skip to content

refactor: move DynamicForm to form-component lib#18894

Merged
adamhaeger merged 2 commits into
mainfrom
refactor/move-DynamicForm-to-app
May 21, 2026
Merged

refactor: move DynamicForm to form-component lib#18894
adamhaeger merged 2 commits into
mainfrom
refactor/move-DynamicForm-to-app

Conversation

@adamhaeger
Copy link
Copy Markdown
Contributor

@adamhaeger adamhaeger commented May 20, 2026

#18811

Description

Moves DynamicForm (and FieldRenderer) from src/App/frontend/src/app-components/DynamicForm/ to the shared libs/form-component package.

  • Adds unit tests and a Storybook story for DynamicForm in the lib.
  • Updates all consumers to import from @app/form-component.

Verification

  • Related issues are connected (if applicable)
  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Warning

Rate limit exceeded

@adamhaeger has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 31 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 23a919b9-875f-4fb8-bd93-7145bc4e11aa

📥 Commits

Reviewing files that changed from the base of the PR and between a64a4b7 and afb2d74.

📒 Files selected for processing (13)
  • libs/form-component/src/app-components/DynamicForm/DynamicForm.stories.tsx
  • libs/form-component/src/app-components/DynamicForm/DynamicForm.test.tsx
  • libs/form-component/src/app-components/DynamicForm/DynamicForm.tsx
  • libs/form-component/src/app-components/DynamicForm/index.ts
  • libs/form-component/src/app-components/Table/Table.test.tsx
  • libs/form-component/src/app-components/Table/Table.tsx
  • libs/form-component/src/app-components/index.ts
  • src/App/frontend/monorepo-changed-paths.txt
  • src/App/frontend/src/layout/AddToList/AddToList.tsx
  • src/App/frontend/src/layout/SimpleTable/ApiTable.tsx
  • src/App/frontend/src/layout/SimpleTable/ApiTableSummary.tsx
  • src/App/frontend/src/layout/SimpleTable/SimpleTableComponent.tsx
  • src/App/frontend/src/layout/SimpleTable/typeguards.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/move-DynamicForm-to-app

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the skip-releasenotes Issues that do not make sense to list in our release notes label May 20, 2026
@adamhaeger adamhaeger merged commit 519e565 into main May 21, 2026
21 of 23 checks passed
@adamhaeger adamhaeger deleted the refactor/move-DynamicForm-to-app branch May 21, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-releasenotes Issues that do not make sense to list in our release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants