Skip to content

Update nuget depencencies#1218

Merged
ivarne merged 3 commits into
mainfrom
chore/ivarne-deps
Mar 30, 2025
Merged

Update nuget depencencies#1218
ivarne merged 3 commits into
mainfrom
chore/ivarne-deps

Conversation

@ivarne

@ivarne ivarne commented Mar 28, 2025

Copy link
Copy Markdown
Member

Notable changes

Replaces

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@ivarne ivarne requested review from Copilot and martinothamar March 28, 2025 21:38
Copilot AI reviewed Mar 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates NuGet dependencies and related configuration, including changes to remove obsolete warnings and update test configurations.

  • Removed the obsolete test for keyed services diagnostics in telemetry tests.
  • Updated the test data retrieval to use [CallerFilePath] instead of assembly location.
  • Removed legacy pragma warnings and adjusted SchemaGenerator initialization in the API controller.

Reviewed Changes

Copilot reviewed 4 out of 14 changed files in this pull request and generated 1 comment.

File Description
test/Altinn.App.Api.Tests/Telemetry/TelemetryConfigurationTests.cs Removed the KeyedServices_Produces_Error_Diagnostics test to align with updated ApplicationInsights package changes.
test/Altinn.App.Api.Tests/Data/TestData.cs Reworked GetTestDataRootDirectory to use [CallerFilePath] instead of assembly location for locating test data.
src/Altinn.App.Core/Extensions/ServiceCollectionExtensions.cs Removed obsolete pragma warnings around AddHybridCache, now using the released version.
src/Altinn.App.Api/Controllers/CustomOpenApiController.cs Updated SchemaGenerator initialization to remove dependency on MvcOptions following the dependency update.
Files not reviewed (10)
  • global.json: Language not supported
  • src/Altinn.App.Api/Altinn.App.Api.csproj: Language not supported
  • src/Altinn.App.Core/Altinn.App.Core.csproj: Language not supported
  • src/Altinn.App.Internal.Analyzers/Altinn.App.Internal.Analyzers.csproj: Language not supported
  • test/Altinn.App.Api.Tests/Altinn.App.Api.Tests.csproj: Language not supported
  • test/Altinn.App.Api.Tests/OpenApi/OpenApiSpecChangeDetection.SaveCustomOpenApiSpec.verified.json: Language not supported
  • test/Altinn.App.Api.Tests/OpenApi/OpenApiSpecChangeDetection.SaveJsonSwagger.verified.json: Language not supported
  • test/Altinn.App.Core.Tests/Altinn.App.Core.Tests.csproj: Language not supported
  • test/Altinn.App.Core.Tests/Internal/App/AppMetadataTest.GetApplicationMetadata_deserialize_serialize_unmapped_properties.verified.txt: Language not supported
  • test/Altinn.App.Tests.Common/Altinn.App.Tests.Common.csproj: Language not supported

Comment thread test/Altinn.App.Api.Tests/Data/TestData.cs
martinothamar
martinothamar approved these changes Mar 30, 2025
View reviewed changes
Comment thread src/Altinn.App.Api/Altinn.App.Api.csproj Outdated
ivarne added 2 commits March 30, 2025 15:23
@ivarne
Update nuget depencencies
4ee55c3 
Notable changes
* Changed from Microsoft.CodeAnalysis.Workspaces to Microsoft.CodeAnalysis.CSharp, in Inernal.Analyzers because of a compiller warning
see: https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1038.md
* Updated SDK reference in global.json
* Updated Applicationinsights package and removed the test from #594
* Updated to released version of HybridCache and remove #pragma waring disable for preview
* Used [CallerFilePath] intead of assemly location to find test data folder.
@ivarne
Revert to Altinn.Platform.Storage.Interface v 4.0.6
7321c1c
@ivarne ivarne force-pushed the chore/ivarne-deps branch from 40eacd3 to 7321c1c Compare March 30, 2025 13:33
@ivarne ivarne added dependency Label Pull requests with dependency updates. Used when generation releasenotes backport This PR should be cherry-picked onto older release branches labels Mar 30, 2025
@ivarne ivarne enabled auto-merge (squash) March 30, 2025 19:32
@ivarne ivarne merged commit 612bc32 into main Mar 30, 2025
@ivarne ivarne deleted the chore/ivarne-deps branch March 30, 2025 19:35
@sonarqubecloud

sonarqubecloud Bot commented Mar 30, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

ivarne added a commit that referenced this pull request Mar 30, 2025
@ivarne
Update nuget depencencies (#1218)
5dad20d 
* Update nuget depencencies

Notable changes
* Changed from Microsoft.CodeAnalysis.Workspaces to Microsoft.CodeAnalysis.CSharp, in Inernal.Analyzers because of a compiller warning
see: https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1038.md
* Updated SDK reference in global.json
* Updated Applicationinsights package and removed the test from #594
* Updated to released version of HybridCache and remove #pragma waring disable for preview
* Used [CallerFilePath] intead of assemly location to find test data folder.
This was referenced Mar 30, 2025
Merged
Closed
Merged
ivarne added a commit that referenced this pull request Apr 4, 2025
@ivarne
Update nuget depencencies (#1218)
150dccb 
* Update nuget depencencies

Notable changes
* Changed from Microsoft.CodeAnalysis.Workspaces to Microsoft.CodeAnalysis.CSharp, in Inernal.Analyzers because of a compiller warning
see: https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1038.md
* Updated SDK reference in global.json
* Updated Applicationinsights package and removed the test from #594
* Updated to released version of HybridCache and remove #pragma waring disable for preview
* Used [CallerFilePath] intead of assemly location to find test data folder.
@ivarne ivarne removed the backport This PR should be cherry-picked onto older release branches label Apr 4, 2025
olamathiesenBlueTree pushed a commit to olamathiesenBlueTree/fork-altinn-app-lib-dotnet that referenced this pull request Apr 8, 2025
@ivarne @olamathiesenBlueTree
Update nuget depencencies (Altinn#1218)
d9dfddd 
* Update nuget depencencies

Notable changes
* Changed from Microsoft.CodeAnalysis.Workspaces to Microsoft.CodeAnalysis.CSharp, in Inernal.Analyzers because of a compiller warning
see: https://github.com/dotnet/roslyn-analyzers/blob/main/docs/rules/RS1038.md
* Updated SDK reference in global.json
* Updated Applicationinsights package and removed the test from Altinn#594
* Updated to released version of HybridCache and remove #pragma waring disable for preview
* Used [CallerFilePath] intead of assemly location to find test data folder.

* Revert to Altinn.Platform.Storage.Interface v 4.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@martinothamar martinothamar martinothamar approved these changes

Assignees

No one assigned

Labels

dependency Label Pull requests with dependency updates. Used when generation releasenotes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivarne @martinothamar