Review 1

[tshemsedinov]

• Decompose and optimize long functions like this:

  Sea-Battle/scripts/game.js

  Line 167 in 474e802

  processCellClick = (x, y) => {

• Use intermediate variables instead of multi-line expressions in if-statements:

  Sea-Battle/scripts/game.js

  Line 167 in 474e802

  processCellClick = (x, y) => {

• Try to combine duplicate code:

  Sea-Battle/scripts/game.js

  Lines 203 to 228 in 474e802

  	processCellMouseEnter = (event) => {
  	const position = parsePositionFromCell(event.target);
  	if (
  	(this.player.game.state === gameState.POSITIONING_PLAYER1 &&
  	this.player.isFirst) ||
  	(this.player.game.state === gameState.POSITIONING_PLAYER2 &&
  	!this.player.isFirst)
  	) {
  	this.renderShip(position.x, position.y, cellState.SHIP);
  	}
  	};
  	processCellMouseLeave = (event) => {
  	const position = parsePositionFromCell(event.target);
  	if (
  	(this.player.game.state === gameState.POSITIONING_PLAYER1 &&
  	this.player.isFirst) ||
  	(this.player.game.state === gameState.POSITIONING_PLAYER2 &&
  	!this.player.isFirst)
  	) {
  	this.renderShip(position.x, position.y, cellState.EMPTY);
  	}
  	};
  	}

[Alzex]

• Combined 2 duplicate functions in one [714301d]
• Optimised if statements and decomposed functions [67c6e28]