bugfix: Fixed clipping issue with cards on dashboard page #2035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Owner
|
Really good solution, thank you for the work put into this. I'll make sure it hits rxresu.me very soon! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixed Card clipping issue on Dashboard page in grid view. Where the sides of the card where being clipped once the hover animation is triggered.
BEFORE
desktop
Mobile
AFTER
Desktop
Mobile
Explanation:
By default ScrollAreaPrimitive.Root sets the class name to 'overflow-hidden'. Then passing a classname with 'overflow-visible' to the scroll-area UI component is not enough. "ScrollAreaPrimitiv.Viewport" applies some extra default styles if the props type='scroll'. I have added a boolean prop type that allows us to disable this and allow bot overflowX and overflowY to be visible in the scenarios where we need it.
Let me know if you need more information.