Skip to content

Conversation

@alay-dev
Copy link

@alay-dev alay-dev commented Oct 12, 2025

The Summary section remains in the main area and cannot be moved to the sidebar, unlike on other pages. (See issue: #2371)

✅ What changed / Fix
Modified the layout logic so the Summary section is eligible to be moved into the sidebar even on page one.

🔗 References
Fixes issue #2371

Summary by CodeRabbit

  • New Features

    • Added a dedicated Summary section accessible via sidebar navigation and app routing.
  • Refactor

    • Ensures Summary is rendered consistently through the app’s section mapping by removing the prior first-page special-case.

@coderabbitai
Copy link

coderabbitai bot commented Oct 12, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Added a "summary" case to mapSectionToComponent to render the Summary component via section mapping and removed the prior isFirstPage-based Summary rendering from the main page.

Changes

Cohort / File(s) Summary
Gengar template routing/rendering
apps/artboard/src/templates/gengar.tsx
Added a case "summary" in mapSectionToComponent to return <Summary />; removed the isFirstPage-conditional rendering of Summary from the main render, centralizing Summary rendering through the section-to-component mapping.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Sidebar as Sidebar Nav
  participant Mapper as mapSectionToComponent
  participant Renderer as Component Renderer

  User->>Sidebar: Select "Summary"
  Sidebar->>Mapper: section="summary"
  Mapper-->>Renderer: returns <Summary />
  Renderer-->>User: Render Summary section
  note over Mapper,Renderer: Summary rendering moved to switch-case mapping
Loading
sequenceDiagram
  autonumber
  participant Old as Old Main Page
  participant New as New Section Mapper

  rect rgba(255,200,200,0.12)
  note right of Old: Previous flow
  Old->>Old: if isFirstPage => render <Summary />
  end

  rect rgba(200,255,200,0.12)
  note right of New: Current flow
  New->>New: case "summary" => render <Summary />
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

I hop through routes where sections align,
No first-page trick — just one clear line.
A switch-case burrow, tidy and neat,
Summary appears where sidebar and mapper meet.
Thump-thump, little rabbit, content complete. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly summarizes the main change by specifying that the Gengar template’s summary section rendering in the sidebar has been fixed, making it concise, focused, and aligned with the pull request’s core objective.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2de24d5 and 87370cf.

📒 Files selected for processing (1)
  • apps/artboard/src/templates/gengar.tsx (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/artboard/src/templates/gengar.tsx (1)

534-536: Summary routing is correct; verify nested background styling in sidebar. The new “summary” case integrates the Summary component as intended. However, both the Summary component and the sidebar container use the same hexToRgb(primaryColor, 0.2) background, leading to nested identical backgrounds—check this against the design.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4efdabd and 2de24d5.

📒 Files selected for processing (1)
  • apps/artboard/src/templates/gengar.tsx (1 hunks)

@AmruthPillai AmruthPillai merged commit e8d6d4a into AmruthPillai:main Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants