Skip to content

Conversation

@Ofsen
Copy link
Contributor

@Ofsen Ofsen commented Nov 3, 2025

Removing puppeteer and using puppeteer-core instead.
Read more here: #2431

Summary by CodeRabbit

  • Chores
    • Switched the browser-automation dependency to a lighter core package and bumped its version.
    • Updated workspace build configuration to reflect the dependency change for consistent builds.

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

📝 Walkthrough

Walkthrough

Replaces Puppeteer with puppeteer-core: import in apps/server/src/printer/printer.service.ts changed, package.json dependency updated to puppeteer-core@^24.28.0, and pnpm-workspace.yaml's onlyBuiltDependencies entry replaced accordingly.

Changes

Cohort / File(s) Change Summary
Import change
apps/server/src/printer/printer.service.ts
Import switched from puppeteer to puppeteer-core (no other code logic changed)
Dependency declarations
package.json
Replaced dependency puppeteer@^23.11.1 with puppeteer-core@^24.28.0
Workspace build config
pnpm-workspace.yaml
Replaced puppeteer with puppeteer-core in onlyBuiltDependencies list

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check apps/server/src/printer/printer.service.ts for any assumptions relying on bundled Chromium (puppeteer-core does not include it).
  • Verify local/CI install and that a Chromium executable is provided or launch options are adjusted.
  • Confirm no other packages or tooling expect the full puppeteer package.

Poem

🐰
From puppets trimmed to core so small,
I hop through code and heed the call.
Lighter paws on browser shore,
Print the pages, then I soar.
A little swap — a lighter haul.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and accurately describes the main change: replacing the puppeteer dependency with puppeteer-core across the codebase.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51fcf13 and f6db9fb.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AmruthPillai
Copy link
Owner

@Ofsen Thank you for the contribution. Looks like a good change, have you verified whether the PrinterService still works after replacing it with puppeteer-core?

@Ofsen
Copy link
Contributor Author

Ofsen commented Nov 4, 2025

@AmruthPillai I didn't fully test it, developement env is weird, had issues with the waitForSelector and host.docker.internal not working ( maybe because am on ubuntu ) but I started the app using the simple.yml, then created a sample resume and exported it to pdf. It gave me a pdf but not separated by pages and the cover avatar image didn't fully load: grieving-sporting-giraffe.pdf
Maybe the pages are not separated because I added the custom section of lorem's ?

@AmruthPillai
Copy link
Owner

That works, I think there's a different issue regarding loading the image. But this change is a welcome one, thank you so much.

@AmruthPillai AmruthPillai merged commit 4368f6a into AmruthPillai:main Nov 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants