Updated CelestialBody.GetOrbit()

[Starstrider42]

I found out the hard way that the orbit property no longer exists, and CelestialBody.GetOrbit() is broken as of 0.24.2. GetOrbitDriver() is still usable, though.

[Anatid]

Are you sure about CelestialBody.GetOrbit()? I'm pretty sure we use it in MechJeb and I haven't noticed it breaking.

[Starstrider42]

I think so... I ran into the issue while experimenting with some Custom Asteroids code. It's possible that the NRE only happens with the Sun (where GetOrbitDriver() returns null, while GetOrbit() throws as described), but whatever the details it's definitely less stable than GetOrbitDriver().

[tomforwood]

I have just tested
CelestialBody sun = Planetarium.fetch.Sun;
CelestialBody kerbin = sun.orbitingBodies.Where(cb => cb.name == "Kerbin").First();
Log("Kerbin orbit="+kerbin.orbit);
Log("Kerbin orbit=" + kerbin.GetOrbit());
and it looks to be producing sensible values