Skip to content

[Bug]: check for gh is done after it is being used for the first time. #591

@PepijnB

Description

@PepijnB

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

in line 159 of entrypoint.sh gh is used to set the authentication. If gh is not installed this will fail with exit code 127 (not so descriptive).

There is a check however in sync_template.sh, however this is exectued later.
Please consider moving the check to the entrypoint.sh

Expected Behavior

Get a proper error message. Something like: github-cli gh is not installed. 'https://github.com/cli/cli'

Current Behavior

Process completed with exit code 127.

Steps To Reproduce

No response

Possible Solution

gh should not be installed on the GitHub runner.

Additional Information/Context

No response

Template sync version Version

v2.4.1

Metadata

Metadata

Labels

bugSomething isn't working

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions