Repository navigation
v0.78.1: Security fixes - #290
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
…rottling Co-authored-by: Codex <noreply@openai.com>
… work Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
…rce budgets Co-authored-by: Codex <noreply@openai.com>
…ions Co-authored-by: Codex <noreply@openai.com>
# Conflicts: # docs/api.md
# Conflicts: # bff/src/routes/auth.ts # bff/test/accountLock.int.test.ts # docs/api.md
Before a password is accepted every refusal stays one answer after one verification. A disabled or locked account is now checked against its own password, and the right one is told why it cannot sign in (403 disabled, 423 locked) instead of "wrong password". Also: the public-fetch dispatcher speaks HTTP/1.1 only (undici 8 offers HTTP/2, whose answers reached Node's fetch undecoded in 8.11.0), a rate-limited sign-in is said in the reader's language, and Discover's recommendations take the token-scope rule too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ver now does them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign-in and account hardening from @globalteddy's report and fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…l being tried With "Finish downloads on their own" on, a refusal is tried until REFUSAL_RETRY_CAP, but "Chapters that would not download" counted it left alone after three. It counts by the sweep's own rule now, and its note says how many tries a refused chapter gets while the switch is on (in all 8 languages). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The default trusts the private networks a home server's proxy lives on, which also trusts any device or container there. Said plainly, with what to set instead, now that sign-in counts wrong passwords per address and name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ne in the database findSources.int demoted its admin by signing a token that claimed 'member'; since sessions take the account's role as it is now, that token is still an admin's, and the test demotes the account instead (which also catches the old rule coming back). sourceAccess.int's token for a deleted account is now refused by authenticate itself, 401, before the add route's own permission check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It signed a token claiming 'user' for its admin; a session takes its account's role as it is now, so that token is still the admin's. A member account of its own is refused, as the check means. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.78.0's Chapter gaps note read "...greyed with what it found.; Numbers none of..." on the live server: a part joins the one before it as a clause unless told otherwise. Both notes added since (gaps.notListedNote, failures.noteRefusals) join as sentences, and finishDownloads.int.test.ts refuses ".;" in either note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.78.1: Security fixes
Hardening for sessions, API tokens, sign-in and the public fetch path, from @globalteddy's fixes, merged with his own commits. Also one Health fix for v0.78.0's finishing downloads.
What changes
authenticatereads the account on every JWT request. A disabled or deleted account gets 401, and the role is the account's current one. Image cookies already did this (accountActive)./api/adminuseactsAsAdmin. That is the account role together with the token's scope: run and job cards, archive actions, an admin's series details, the canDownload exemption, and Discover's recommendations.lib/publicConnection.tschecks the addresses the socket actually connects to and hands only those to it. It serves covers, icons and every page download past the engine's first hop.allowH2: false). undici 8.11.0's HTTP/2 answers once reached Node's fetch undecoded (fix: preserve HTTP/2 for non-upgrade legacy requests nodejs/undici#5811).Retry-After.invalid_credentials, after one verification each (lib/loginPassword.ts, a dummy hash at the app's parameters).disabledor 423locked.retryCapFor). Its note says the refusal cap while "Finish downloads on their own" is on, in all 8 languages.docs/api.mdanddocs/USAGE.md, and when to narrowTRUST_PROXYto the proxy's own address. The default is unchanged.Tests
His focused tests:
currentJwtAuthority.int,inlineAdminScope.int,publicConnection,coverUrlGuard.int(a no-private-socket assertion),sourcePasswordThrottle.int,uniformPasswordRefusal.int.Reintroductions, after an unmodified baseline through the same command. Each fails its own test:
authenticatecurrentJwtAuthorityroleOfon run cancelinlineAdminScopefetchfor the cover hopcoverUrlGuardsourcePasswordThrottleuniformPasswordRefusaluniformPasswordRefusalaccountLock(the right password told it is wrong)finishDownloads.int"Health says a refused chapter is still being tried"Tests that changed meaning:
accountLockassertions go back to 423 for the right password while locked.findSources.intdemoted its admin with a token claimingmember, andhealthSummary.intsigneduserfor an admin. Both now use the database, since a token's role claim no longer counts.sourceAccess.int: a deleted account's token is 401 atauthenticate.Full sharded bff suite on this tree: 3519/3530 before those three test files were updated.
releasePipeline's Umbrel pin, which moves to v0.78.0 here.Web suite: 1494/1494 (TZ=UTC). Both typechecks are clean.
🤖 Generated with Claude Code