Skip to content

[1.1.3] P2P: Fix node stuck in head catchup #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

[1.1.3] P2P: Fix node stuck in head catchup #1240

merged 1 commit into from
Mar 7, 2025

Conversation

heifner
Copy link
Member

@heifner heifner commented Mar 6, 2025

#688 introduced an incorrect handling of null connection when determining node catchup state.

Resolves #1239

@heifner heifner added the OCI Work exclusive to OCI team label Mar 6, 2025
@heifner heifner requested review from greg7mdp and linh2931 March 6, 2025 19:50
@heifner heifner added this to the Spring v1.1.3 milestone Mar 6, 2025
greg7mdp
greg7mdp reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@greg7mdp greg7mdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this not crash if we were dereferencing a null pointer?

@linh2931
Copy link
Member

linh2931 commented Mar 6, 2025

How did this not crash if we were dereferencing a null pointer?

Wasn't c checked first?

@greg7mdp
Copy link
Contributor

greg7mdp commented Mar 6, 2025

Wasn't c checked first?

Thanks, missed that!

@heifner heifner merged commit 81e2b0f into release/1.1 Mar 7, 2025
36 checks passed
@heifner heifner deleted the GH-1239-p2p-stuck-in-head-catchup-1.1 branch March 7, 2025 12:14
@heifner heifner mentioned this pull request Mar 7, 2025
Merged
@heifner heifner linked an issue Mar 7, 2025 that may be closed by this pull request
Investigate net_plugin stuck in sync_state head catchup #1239
Closed
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: P2P
summary: Fix node stuck in head catchup, resolves issues related to null connections.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
Spring v1.1.3
Development

Successfully merging this pull request may close these issues.

Investigate net_plugin stuck in sync_state head catchup
4 participants
@heifner @linh2931 @greg7mdp @ericpassmore