[1.1.3] Test fix: Decrease max_block_cpu_usage and max_transaction_cpu_usage values #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
approved these changes
Mar 28, 2025
heifner
changed the title
greg7mdp
approved these changes
Mar 28, 2025
[1.1.3] Ignore block cpu limit for read-only trxs
|
Note:start |
This was referenced Apr 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1151 (comment) for a detailed discussion of the test failure scenario.
Looks like #1172 didn't change all tests to use mainnet values. Some still run with 475ms trx time.
Ideally it would be nice to run ci/cd with EOS Mainnet values for
max_block_cpu_usageandmax_transaction_cpu_usage. However, this puts us in a situation where tests will be flakey because transactions hit the time limit. See for example:https://github.com/AntelopeIO/spring/actions/runs/14131407538/job/39593258845
https://github.com/AntelopeIO/spring/actions/runs/14131407538/job/39593259641
https://github.com/AntelopeIO/spring/actions/runs/14131694179/job/39594280368
This PR reduces the value to something hopefully large enough for ci/cd without getting into the pathological case of #1151 (comment)
Note: read-only trx tests were failing on this PR because of an issue with read-only trxs, see #1286. Fixed by #1288 which has been merged into this PR.
Resolves #1278