[1.2.0-rc3] Test: Relax hard thread test #1530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imes a thread doesn't actually run a task.
linh2931
reviewed
May 19, 2025
| BOOST_CHECK(run_on_2 > 0); | ||
| BOOST_CHECK(run_on_3 > 0); | ||
| BOOST_CHECK(run_on_main > 0); | ||
| // We expect at least one to run on every thread including main, but nothing guarantees that |
There was a problem hiding this comment.
Because we already have BOOST_REQUIRE_EQUAL(run_on_1+run_on_2+run_on_3+run_on_main, num_expected);, can we just remove those BOOST_WARN checks?
There was a problem hiding this comment.
I'm ok with removing them. @greg7mdp what do you think?
greg7mdp
approved these changes
May 19, 2025
linh2931
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not require every thread to run a task in test. In practice sometimes a thread doesn't actually run a task. There is nothing that would guarantee every thread runs at least one task, so don't require it.
Resolves #1502