Update maxQueuingCompounded in BulkheadSemaphoreFactory#2638
Merged
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
Member
|
Thanks for the PR - could you add a test for this please that validates the exception is no longer thrown? |
Contributor
Author
|
@martincostello added unit tests |
martincostello
approved these changes
Jun 10, 2025
Co-authored-by: Martin Costello <martin@martincostello.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7329 7329
Branches 1013 1013
=======================================
Hits 7053 7053
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
Thanks! |
This was referenced Jul 22, 2025
This was referenced Jul 29, 2025
This was referenced May 24, 2026
This was referenced Jun 2, 2026
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
Fixes #2637, caused by overflow in
BulkheadSemaphoreFactory.Details on the issue fix or feature implementation
Set compound math to long before evaluating Min with int.MaxValue.
Confirm the following