AP_Networking: disable asserts for production builds #31597
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Just doing an infinite loop if this is called saves 13k still. |
The string description for the asserts was costing us a lot of flash for not a lot of gain. By not displaying those strings in production builds we save about 11k
tridge
force-pushed
the
pr-lwip-assert-sitl-only
branch
from
3ffcacd to
041ba6e
Compare
Contributor
Author
I've changed it to keep using panic (which is an infinite loop with delay) but to not pass the string descriptions. That saves us 11k |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the AP::panic() isn't really very useful, and this costs us 15k of flash