Test on push (not just on pull request) #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfoster
changed the title
Collaborator
|
In my local branch, I had enabled "Test on push" for just the Linux runner, is that sufficient? I can also make the change in the documentation ("produces" -> "should produce") if so. |
Member
Author
|
Yes, Linux |
ianfixes
approved these changes
Sep 23, 2021
Collaborator
ianfixes
left a comment
ianfixes
left a comment
There was a problem hiding this comment.
Re-reading the GitHub docs about billing, all open-source repositories seem to be allowed no-cost use of GitHub Actions... so there is no financial impact to this change (which was my original reason for not testing both pushes and pull requests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that when I made a change and pushed to my fork the tests were not run. I'd like to have them run so I can confirm my work before I submit a Pull Request. This addresses that need.