Skip to content

refactor(core-state): fire wallet events #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 8, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Oct 1, 2020

Summary

Move wallet events from core-manager into core-state. Events are fired only for main wallet repository. Wallet factory now also injects events into Wallet. This events parameter is optional and isn't injected in pool, forger, or after cloning.

  • Ready to be merged

@ghost ghost added Complexity: High labels Oct 1, 2020
@rainydio rainydio marked this pull request as draft October 1, 2020 14:37
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #4076 into develop will increase coverage by 1.22%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4076      +/-   ##
===========================================
+ Coverage    95.43%   96.66%   +1.22%     
===========================================
  Files          716      716              
  Lines        17232    17227       -5     
  Branches      2094     2095       +1     
===========================================
+ Hits         16446    16653     +207     
+ Misses         629      416     -213     
- Partials       157      158       +1     
Flag Coverage Δ
#functional 5.97% <0.00%> (?)
#integration 10.06% <0.00%> (+<0.01%) ⬆️
#unit 95.31% <84.61%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-state/src/wallets/wallet-event.ts 100.00% <ø> (ø)
...re-kernel/src/services/attributes/attribute-map.ts 88.00% <25.00%> (-12.00%) ⬇️
packages/core-state/src/service-provider.ts 93.18% <62.50%> (-6.82%) ⬇️
packages/core-manager/src/service-provider.ts 100.00% <100.00%> (ø)
.../core-state/src/wallets/indexers/wallet-indexes.ts 100.00% <100.00%> (+6.66%) ⬆️
packages/core-state/src/wallets/wallet-factory.ts 100.00% <100.00%> (ø)
packages/core-state/src/wallets/wallet.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/network-monitor.ts 99.62% <0.00%> (-0.38%) ⬇️
packages/core-database/src/utils/transform.ts 100.00% <0.00%> (+25.00%) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a13bf61...3660ecd. Read the comment docs.

@rainydio rainydio marked this pull request as ready for review October 7, 2020 02:50
@faustbrian faustbrian merged commit 2c43f6c into develop Oct 8, 2020
@ghost ghost deleted the refactor/core-state/wallet-events branch October 8, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants