Merged
Conversation
Arker123
requested changes
Feb 19, 2024
client/src/components/SignUp.jsx
Outdated
| animate={{ opacity: 1, y: 0 }} | ||
| transition={{ duration: 1, delay: 0.5 }} | ||
| className="text-[40px] flex flex-row items-start gap-1 text-white relative font-serif font-bold mb-4" | ||
| // style={{ marginLeft: '20px', marginTop: '50px' }} |
Owner
There was a problem hiding this comment.
Suggested change
| // style={{ marginLeft: '20px', marginTop: '50px' }} |
client/src/components/SignUp.jsx
Outdated
Comment on lines
+2
to
+3
| import img from './img1.jpg'; | ||
| import img1 from './img4.jpg'; |
Owner
There was a problem hiding this comment.
Let's use more descriptive names
client/src/components/SignUp.jsx
Outdated
| <div className=''> | ||
| <motion.div | ||
| className=" flex flex-row bg-gradient-to-b from-red-500 via-red-900 to-black" | ||
| // style={{ backgroundImage: `url(${img})` }} |
Owner
There was a problem hiding this comment.
Suggested change
| // style={{ backgroundImage: `url(${img})` }} |
client/src/components/img1.jpg
Outdated
Owner
There was a problem hiding this comment.
Let's use a more descriptive name for this image
Merged
Owner
Apologies for any confusion. Can we change the variable names to something like "image_logo.png" instead of "image1.png"? It'll make things more descriptive for future contributers. Thanks. |
ViratJain06
approved these changes
Mar 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signup and login page is added