Skip to content

2021csb1073/sof 216 member2#250

Merged
Dhananjay-Goel merged 10 commits intoArker123:mainfrom
ARinger22:2021csb1073/sof-216-member2
May 8, 2024
Merged

2021csb1073/sof 216 member2#250
Dhananjay-Goel merged 10 commits intoArker123:mainfrom
ARinger22:2021csb1073/sof-216-member2

Conversation

@ARinger22
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Apr 26, 2024

SOF-216 Member2

Signed-off-by: Arpit Kumar Gautam  <gautamarpit1204@gmail.com>
@gitguardian
Copy link

gitguardian bot commented Apr 26, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Google API Key 205187c condense/comments.py View secret
- Google API Key 18d503c condense/comments.py View secret
- Google API Key 7f1f168 condense/comments.py View secret
- Google API Key c9fc49e condense/comments.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ARinger22 ARinger22 requested review from Hardik329 and removed request for Arker123 May 8, 2024 08:56
Copy link
Collaborator

@Dhananjay-Goel Dhananjay-Goel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dhananjay-Goel Dhananjay-Goel enabled auto-merge May 8, 2024 08:57
@Dhananjay-Goel Dhananjay-Goel requested a review from ViratJain06 May 8, 2024 08:57
Copy link
Collaborator

@ViratJain06 ViratJain06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dhananjay-Goel Dhananjay-Goel merged commit f42d01f into Arker123:main May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants