More aggressive inlining and slightly reworked pass pipeline again #1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGraey
changed the title
dcodeIO
reviewed
Feb 29, 2020
cli/asc.js
Outdated
| if (optimizeLevel >= 2 && shrinkLevel === 0) { | ||
| module.setAlwaysInlineMaxSize(12); | ||
| module.setFlexibleInlineMaxSize(60); | ||
| module.setOneCallerInlineMaxSize(60); |
There was a problem hiding this comment.
What would be the downside of making OneCallerInlineMaxSize basically unlimited? Just curious :)
There was a problem hiding this comment.
Infinite code size? =) Basically it significantly increase build speed. Also it could even slowdown code due to inline huge functions will increase register pressure and stack usage on target platform
MaxGraey
changed the title
MaxGraey
changed the title
dcodeIO
reviewed
Mar 13, 2020
dcodeIO
reviewed
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.