Always register non-MVP types and check on actual use#1194
Merged
Conversation
Contributor
|
Should I validate that this works locally? |
Member
Author
|
Would be great :) |
Contributor
|
After waiting about ten minutes for the dist files to generate, it appears this works locally for me. class Test {
a: f32 = 0.0;
b: f32 = 0.0;
c: f32 = 0.0;
d: f32 = 0.0;
get abcd(): v128 {
return v128.load(changetype<usize>(this), offsetof<Test>("a"));
}
set abcd(value: v128) {
v128.store(changetype<usize>(this), value, offsetof<Test>("a"));
}
}
let a = new Test();
if (ASC_FEATURE_SIMD) {
let vec = v128.mul<f32>(a.abcd, v128.splat<f32>(2));
a.abcd = vec;
} else {
a.a *= 2;
a.b *= 2;
a.c *= 2;
a.d *= 2;
}It compiles when simd is enabled and when simd is not enabled. Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix #1162 in that
v128andanyrefwill always be present, even if the respective feature is not enabled, so these can be used conditionally. Chances are that I am missing diagnostics somewhere, but general strategy is to check on use of a storage typeand when a new value of the type is created by one of the respective builtins, which should also cover all sorts of inference if no type is annotated on a storage type. That should give us the minimum amount of diagnostics, instead of erroring on every single compiled expression resolving to that type, along minimal checking overhead.
Unless discovered in review, we'll notice that a diagnostic is missing if Binaryen fails to validate a module due to unexpected types.