Skip to content

Support StaticArray in loader #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 28, 2020
Merged

Support StaticArray in loader #1197

merged 8 commits into from
Mar 28, 2020

Conversation

jtenner
Copy link
Contributor

@jtenner jtenner commented Mar 27, 2020

No description provided.

@jtenner
Copy link
Contributor Author

jtenner commented Mar 27, 2020

Loader finally passed 🎉 .

This pull request contains fixes for:

  • __allocArray()
  • __getArray()

These methods now work with StaticArray types.

Should we add __allocStaticArray() and __getStaticArray() or leave everything as is?

dcodeIO
dcodeIO reviewed Mar 28, 2020
View reviewed changes
@dcodeIO dcodeIO merged commit 9e05906 into AssemblyScript:master Mar 28, 2020
@dcodeIO
Copy link
Member

dcodeIO commented Mar 28, 2020

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtenner @dcodeIO