Fix invalid store offsets in memset polyfill #1787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the stores in
memset
are invalid for certain arguments due to enforcing a constant offset where we'd instead want the whole offset to wrap around. Traced this back to #1103 where I assumed that we'd be using lowMemoryUnused anyhow (i.e. never storing to the low 1024 bytes of memory), which actually isn't always the case inmemset
.Discovered in #1785.