Skip to content

Refactor unsafe #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Refactor unsafe #477

wants to merge 6 commits into from

Conversation

jtenner
Copy link
Contributor

@jtenner jtenner commented Feb 8, 2019

@dcodeIO seemed to think that we could redesign how reallocateUnsafe() works for ArrayBuffer. This pull request aims to do the following things:

  • Standardize reallocateUnsafe and allocateUnsafe to avoid zeroing of data
  • Add reallocateZeroedUnsafe and allocateZeroedUnsafe to zero out the data
  • Replace instances of unsafe methods to reallocateZeroedUnsafe and allocateZeroedUnsafe respectively for backwards compatibility

@jtenner
Copy link
Contributor Author

jtenner commented May 8, 2019

It's become painfully obvious that this pull request is not going to solve the problem (if it even was a problem in the first place.)

Closing in favor of #535 obviously.

@jtenner jtenner closed this May 8, 2019
@jtenner jtenner deleted the refactor-unsafe branch May 8, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jtenner