Skip to content

Improve holey array handling and remove Array.create #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2019
Merged

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Sep 20, 2019

This is an implementation of the suggestion made in #853 in that it removes the need to use non-standard Array.create<T>(length > 0) over new Array<T>(length > 0) while moving that check to actually accessing an array's elements, throwing if there's an unexpected null in it as a result of not properly initializing it.

@dcodeIO dcodeIO merged commit af864c1 into master Sep 23, 2019
@dcodeIO dcodeIO deleted the no-array-create branch November 8, 2019 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant