This repository was archived by the owner on Aug 7, 2023. It is now read-only.
Bugfixes #155
Merged
Bugfixes #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this never got cleaned up in #148.
Before there was a race condition as to whether the package was activating properly or not.
Atom has only supported the configSchema since v1.4.0.
|
Hmmm, looks like it wasn't the race condition in package activation in the specs that caused the earlier CI failure... |
|
Okay, so it looks like the Electron update in Atom v1.12.0 broke execution of the When running this script manually under Node.js v7 the following warnings are thrown: So I'm guessing something is rather broken in the |
|
Looks like this is actually code introduced by @steelbrain as part of the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few bugs:
lintscript