Skip to content

Input/HookManager Rework #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Sep 3, 2022
Merged

Input/HookManager Rework #42

merged 31 commits into from
Sep 3, 2022

Conversation

AustinJ235
Copy link
Owner

@AustinJ235 AustinJ235 commented Aug 21, 2022

  • This combines Input and HookManager into one type.
  • Preparations will be made for when Basalt will have multiple window support.
  • Convenience methods on Bin will stay, but the signature will change.
  • Convenience methods instead of being access on Input will instead be on windows.
  • Add new interval system that will be used by Input and for externally.
    • Use high resolution timers for smoother animations and inputs.

TODO:

  • Convert convenience methods over to new Input
  • Remove old Input and HookManger
  • Remove BinStyle.pass_events
    • Functionality made be required to some extent yet, maybe rename to pass_scroll? Issue is mainly with bins being scrolled within other bins. Impl'd by upper_blocks.
  • Rename InputV2 to Input
  • Testing with Xorg and Wayland
  • mouse_inside() may no longer function as intended by games. If there was a Bin that covers the game's view and it was expected for this method to return true before, this is no longer the case as pass_events no longer exists.

Status

🟢 Complete
⚪ Incomplete
⚫ Not Planned/Applicable

Window Bin None
Press 🟢 🟢
Hold 🟢 🟢
Release 🟢 🟢
Character 🟢 🟢
Cursor 🟢 🟢
Scroll 🟢 🟢
Enter 🟢 🟢
Leave 🟢 🟢
Focus 🟢 🟢
FocusLost 🟢 🟢
Motion 🟢

send events to new input, create input-test example (temp), fix release issues & InputV2 is no longer in an Arc
Weights are now also used in Release
Remove release builder and combine with press builder. Renamed generic builder to focus and remove enter/leave varients. Add enter builder.
@AustinJ235 AustinJ235 mentioned this pull request Aug 26, 2022
@AustinJ235 AustinJ235 marked this pull request as ready for review September 3, 2022 00:21
@AustinJ235 AustinJ235 merged commit e5f2d56 into master Sep 3, 2022
@AustinJ235 AustinJ235 deleted the input-rework branch September 18, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant