Correctly remember last url when multiple blocks are on the same page #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple blocks are on the same page, in different screens (e.g. different rooms), refreshing the page would not correctly bring each block to the screen where they were previously on.
This PR fixes that by introducing an
instanceId
attribute which is unique for each block on a page. We then use thatinstanceId
to namespace thechatrix_last_url_hash
property in local storage, so that it becomeschatrix_abc123_last_url_hash
(whereabc123
is theinstanceId
).Note: For blocks created before this PR, the pages will need to be re-saved for the block(s) to get an
instanceId
.Screen recording
Screen.Recording.2023-04-17.at.16.34.20.mov