Skip to content

Yarn: install specific stable version in build script. #5635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2016

Conversation

dereksmart
Copy link
Member

@dereksmart dereksmart commented Nov 14, 2016

Yarn 0.17.0 has some issues installing dependencies from external repositories. Let's make sure to install only the yarn version that works until we have time to test upcoming yarn releases, as this breaks the build when using the build script, and fails travis.

related yarn issue: yarnpkg/yarn#1818

This PR also makes sure to clear the yarn cache during the build.

cc @eliorivero for review.

Yarn 0.17.0 has some issues installing dependencies from external repositories.  Let's make sure to install only the yarn version that works until we have time to test upcoming yarn releases, as this breaks the build when using the build script.

related yarn issue: yarnpkg/yarn#1818
@dereksmart dereksmart added [Status] Needs Review This PR is ready for review. [Type] Bug When a feature is broken and / or not performing as intended [Type] Janitorial labels Nov 14, 2016
@dereksmart dereksmart added this to the 4.4 milestone Nov 14, 2016
@eliorivero
Copy link
Contributor

Merging as this solves Travis builds

@eliorivero eliorivero merged commit 77ad1b2 into master Nov 14, 2016
@eliorivero eliorivero deleted the fix/stable-yarn-version branch November 14, 2016 19:38
@eliorivero eliorivero removed the [Status] Needs Review This PR is ready for review. label Nov 14, 2016
@dereksmart dereksmart restored the fix/stable-yarn-version branch November 14, 2016 21:14
@dereksmart
Copy link
Member Author

@zinigor I cherry-picked this into branch-4.4

@dereksmart dereksmart deleted the fix/stable-yarn-version branch November 14, 2016 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug When a feature is broken and / or not performing as intended [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants