Skip to content

Detect invalid PNG and prevent segfault #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Detect invalid PNG and prevent segfault #1324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/image.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ describe('Image', function () {
})
})

it('detects invalid PNG', function (done) {
const img = new Image()
img.onerror = () => done()
img.src = Buffer.from('89504E470D', 'hex')
})

it('loads SVG data URL base64', function () {
const base64Enc = fs.readFileSync(svg_tree, 'base64')
const dataURL = `data:image/svg+xml;base64,${base64Enc}`
Expand Down