Skip to content

re-enable pango, use fontconfig and floats for drawImage() #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2015

Conversation

jakeg
Copy link
Contributor

@jakeg jakeg commented Dec 9, 2014

  • Pango seems to work fine for me (what's the issue its supposed to cause with freetype?) and means I can have fallback fonts, better kerning etc.
  • Fontconfig enables finding fonts when using Pango (see also Font Encoding or Secondary font #266 (comment)).
  • I have a need for floats rather than ints for the drawImage() arguments.

@terrancesnyder
Copy link

+1 on this

terrancesnyder added a commit to terrancesnyder/node-canvas that referenced this pull request Dec 14, 2014
@jengel3
Copy link

jengel3 commented Dec 17, 2014

👍 on the floats for drawImage, PR'd this myself because it causes so many issues.

@kangax
Copy link
Collaborator

kangax commented Jan 19, 2015

I have a need for floats rather than ints for the drawImage() arguments.

Looks like we should change this indeed. I see drawImage arguments are defined as "double" (http://www.w3.org/TR/2dcontext/#conformance-requirements) which is "a floating point numeric type that corresponds to the set of finite double-precision 64 bit IEEE 754 floating point numbers" (http://www.w3.org/TR/WebIDL/#idl-double)

I don't know about points 1 and 2.

@rvagg @TooTallNate could you folks take a look?

@rvagg
Copy link
Contributor

rvagg commented Jan 20, 2015

lgtm, would be nice to have someone confirm that it compiles and works properly without pango with this one applied; @kangax if you don't get anyone doing that just merge and release and see who complains! That ultimately may be the best way to make this project move forward, i.e. upset a few people and make a bit of noise.

@kangax
Copy link
Collaborator

kangax commented Jan 20, 2015

@rvagg yep, that's one way to do it :)

kangax added a commit that referenced this pull request Jan 21, 2015
re-enable pango, use fontconfig and floats for drawImage()
@kangax kangax merged commit 9a3bde4 into Automattic:master Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants