src(build): port has_lib.js to javascript #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbjornson
force-pushed
the
has-lib-js
branch
2 times, most recently
from
7c0afda to
4358092
Compare
Open
|
Amazing work! Would you mind adding this file to the standard list here package.json#L27 and update the file to follow standard style? ( |
zbjornson
force-pushed
the
has-lib-js
branch
from
4358092 to
c418645
Compare
|
My poor semicolons! 😜 Change made. |
Ref Automattic#754 (fix build on BSD) Ref Automattic#813 (static build)
zbjornson
force-pushed
the
has-lib-js
branch
from
c418645 to
5702c47
Compare
|
Hehe, thank you 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Windows. CI covers some sort of linux. Would be good for someone with MacOS and BSD (@hakkiplaten? @ronelliott?) to test.
Ref #754 (fix build on BSD)
Ref #813 (static build)